From afedf74f8fdea382f06b950bc5c9aff59179278e Mon Sep 17 00:00:00 2001
From: Christian Merten <christian@merten.dev>
Date: Tue, 19 Aug 2025 00:07:14 +0200
Subject: [PATCH] chore(tests/material): add models and admin tests

---
 jdav_web/material/tests.py | 130 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 127 insertions(+), 3 deletions(-)

diff --git a/jdav_web/material/tests.py b/jdav_web/material/tests.py
index 53ee4ec..c736ce6 100644
--- a/jdav_web/material/tests.py
+++ b/jdav_web/material/tests.py
@@ -1,8 +1,10 @@
-from django.test import TestCase
+from django.test import TestCase, RequestFactory
 from django.utils import timezone
-from datetime import date
+from datetime import date, datetime
 from decimal import Decimal
-from material.models import MaterialCategory, MaterialPart, Ownership
+from unittest.mock import Mock
+from material.models import MaterialCategory, MaterialPart, Ownership, yearsago
+from material.admin import NotTooOldFilter, MaterialAdmin
 from members.models import Member, MALE, FEMALE, DIVERSE
 
 
@@ -75,6 +77,37 @@ class MaterialPartTestCase(TestCase):
             self.assertTrue(hasattr(field, 'verbose_name'))
             self.assertIsNotNone(field.verbose_name)
 
+    def test_admin_thumbnail_with_photo(self):
+        """Test admin_thumbnail when photo exists"""
+        mock_photo = Mock()
+        mock_photo.url = "/media/test.jpg"
+        self.material_part.photo = mock_photo
+        result = self.material_part.admin_thumbnail()
+        self.assertIn("/media/test.jpg", result)
+        self.assertIn("<img", result)
+
+    def test_admin_thumbnail_without_photo(self):
+        """Test admin_thumbnail when no photo exists"""
+        self.material_part.photo = None
+        result = self.material_part.admin_thumbnail()
+        self.assertIn("kein Bild", result)
+
+    def test_ownership_overview(self):
+        """Test ownership_overview method"""
+        Ownership.objects.create(material=self.material_part, owner=self.member, count=2)
+        result = self.material_part.ownership_overview()
+        self.assertIn(str(self.member), result)
+        self.assertIn("2", result)
+
+    def test_not_too_old(self):
+        """Test not_too_old method"""
+        # Set a buy_date that makes the material old
+        old_date = date(2000, 1, 1)
+        self.material_part.buy_date = old_date
+        self.material_part.lifetime = Decimal('5')
+        result = self.material_part.not_too_old()
+        self.assertFalse(result)
+
 
 class OwnershipTestCase(TestCase):
     def setUp(self):
@@ -112,3 +145,94 @@ class OwnershipTestCase(TestCase):
         ownerships = Ownership.objects.filter(material=self.material_part)
         self.assertEqual(ownerships.count(), 1)
         self.assertEqual(ownerships.first(), self.ownership)
+
+    def test_str(self):
+        """Test string representation of Ownership"""
+        result = str(self.ownership)
+        self.assertEqual(result, str(self.member))
+
+
+class UtilityFunctionTestCase(TestCase):
+    def test_yearsago_with_from_date(self):
+        """Test yearsago function with explicit from_date"""
+        test_date = timezone.make_aware(datetime(2020, 5, 15, 12, 0, 0))
+        result = yearsago(5, from_date=test_date)
+        expected = timezone.make_aware(datetime(2015, 5, 15, 12, 0, 0))
+        self.assertEqual(result, expected)
+
+    def test_yearsago_default_from_date(self):
+        """Test yearsago function with default from_date (None)"""
+        # This will use timezone.now() internally
+        result = yearsago(1)
+        self.assertIsNotNone(result)
+        self.assertLess(result, timezone.now())
+
+    def test_yearsago_leap_year_edge_case(self):
+        """Test yearsago function with leap year edge case (Feb 29)"""
+        # Feb 29, 2020 (leap year) minus 1 year should become Feb 28, 2019
+        leap_date = timezone.make_aware(datetime(2020, 2, 29, 12, 0, 0))
+        result = yearsago(1, from_date=leap_date)
+        expected = timezone.make_aware(datetime(2019, 2, 28, 12, 0, 0))
+        self.assertEqual(result, expected)
+
+
+class NotTooOldFilterTestCase(TestCase):
+    def setUp(self):
+        self.factory = RequestFactory()
+        self.filter = NotTooOldFilter(None, {}, MaterialPart, MaterialAdmin)
+
+        # Create test data
+        self.member = Member.objects.create(
+            prename="Test", lastname="User", birth_date=date(1990, 1, 1),
+            email="test@example.com", gender=MALE
+        )
+
+        # Create old material (should be too old)
+        self.old_material = MaterialPart.objects.create(
+            name="Old Material",
+            description="Old material",
+            quantity=1,
+            buy_date=date(2000, 1, 1),  # Very old
+            lifetime=Decimal('5')
+        )
+
+        # Create new material (should not be too old)
+        self.new_material = MaterialPart.objects.create(
+            name="New Material",
+            description="New material",
+            quantity=1,
+            buy_date=date.today(),  # Today
+            lifetime=Decimal('10')
+        )
+
+    def test_not_too_old_filter_lookups(self):
+        """Test NotTooOldFilter lookups method"""
+        request = self.factory.get('/')
+        lookups = self.filter.lookups(request, None)
+        self.assertEqual(len(lookups), 2)
+        self.assertEqual(lookups[0][0], 'too_old')
+        self.assertEqual(lookups[1][0], 'not_too_old')
+
+    def test_not_too_old_filter_queryset_too_old(self):
+        """Test NotTooOldFilter queryset method with 'too_old' value"""
+        request = self.factory.get('/?age=too_old')
+        self.filter.used_parameters = {'age': 'too_old'}
+
+        queryset = MaterialPart.objects.all()
+        filtered = self.filter.queryset(request, queryset)
+
+        # Should return materials that are not too old (i.e., new materials)
+        self.assertIn(self.new_material, filtered)
+        self.assertNotIn(self.old_material, filtered)
+
+    def test_not_too_old_filter_queryset_not_too_old(self):
+        """Test NotTooOldFilter queryset method with 'not_too_old' value"""
+        request = self.factory.get('/?age=not_too_old')
+        self.filter.used_parameters = {'age': 'not_too_old'}
+
+        queryset = MaterialPart.objects.all()
+        filtered = self.filter.queryset(request, queryset)
+
+        # Should return materials that are too old
+        self.assertIn(self.old_material, filtered)
+        self.assertNotIn(self.new_material, filtered)